vschema: allow pins in vschema#4134
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 16, 2018
sougou:pin
Merged
Conversation
Pinning was an internal feature used for pinning the dual table to shard 0. Exposing this ability in vschema allows someone to pin an unsharded table to a specific shard. This is still not a full feature because we ned to think about the various use cases like resharding etc. But it can be used for testing purposes. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Member
|
I see nothing wrong with the code but I'm unconvinced by the motivations for why someone would want to do this? Wouldn't it be better to put all unsharded tables into a separate unsharded keyspace? |
Contributor
Author
|
This is for those who are transitioning from bare-metal single mysql per machine type of setup. A separate keyspace becomes very expensive because they don't have the process in place to spin up multiple mysql instances per box. There is also the argument that you don't want to create a keyspace just to store a single-row sequence table. |
demmer
approved these changes
Aug 15, 2018
Member
demmer
left a comment
demmer
left a comment
There was a problem hiding this comment.
I see. That all makes sense. Lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinning was an internal feature used for pinning the
dual table to shard 0. Exposing this ability in vschema
allows someone to pin an unsharded table to a specific
shard.
This is still not a full feature because we ned to
think about the various use cases like resharding etc.
But it can be used for testing purposes.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com